Version con fallas

2026-02-12 14:00:04 -07:00
parent 96cd09476c
commit 2033a35a2b
44 changed files with 196 additions and 3723 deletions
--- a/backend/app/api/v1/endpoints/tickets.py
+++ b/backend/app/api/v1/endpoints/tickets.py
@@ -78,188 +78,85 @@ async def create_ticket(
    """
    Crear un nuevo ticket
    """
-    # Retry logic para evitar race conditions en generación de ticket_number
-    max_retries = 3
-    last_error = None
-    
-    for attempt in range(max_retries):
-        try:
-            # Generar número de ticket único basado en el máximo existente
-            result = await db.execute(
-                select(Ticket.ticket_number)
-                .where(Ticket.tenant_id == current_user.tenant_id)
-                .order_by(Ticket.ticket_number.desc())
-                .limit(1)
-            )
-            last_ticket_number = result.scalar_one_or_none()
-            
-            if last_ticket_number:
-                # Extraer el número del formato TK-XXXXXX
-                last_number = int(last_ticket_number.split('-')[1])
-                next_number = last_number + 1
-            else:
-                next_number = 1
-            
-            ticket_number = f"TK-{next_number:06d}"
-            
-            # Convertir IDs de string a UUID si son proporcionados
-            category_uuid = uuid.UUID(ticket.category_id) if ticket.category_id else None
-            system_uuid = uuid.UUID(ticket.affected_system_id) if ticket.affected_system_id else None
-            
-            # Validar categoría
-            if category_uuid:
-                category = await db.get(Category, category_uuid)
-                if not category:
-                    raise HTTPException(
-                        status_code=status.HTTP_400_BAD_REQUEST,
-                        detail=f"La categoría con ID {ticket.category_id} no existe."
-                    )
+    try:
+        # Generar número de ticket único
+        result = await db.execute(
+            select(func.count(Ticket.id)).where(Ticket.tenant_id == current_user.tenant_id)
+        )
+        count = result.scalar() or 0
+        ticket_number = f"TK-{count + 1:06d}"
+        
+        # Generar número de ticket único
+        result = await db.execute(
+            select(func.count(Ticket.id)).where(Ticket.tenant_id == current_user.tenant_id)
+        )
+        count = result.scalar() or 0
+        ticket_number = f"TK-{count + 1:06d}"
+        
+        # Convertir IDs de string a UUID si son proporcionados
+        category_uuid = uuid.UUID(ticket.category_id) if ticket.category_id else None
+        system_uuid = uuid.UUID(ticket.affected_system_id) if ticket.affected_system_id else None  # ✅ CORREGIDO
+        
+        # ✅ CORREGIDO: Validar en la tabla correcta con el nombre correcto del modelo
+        if category_uuid:
+            category = await db.get(Category, category_uuid)  # ✅ Category, no TicketCategory
+            if not category:
+                raise HTTPException(
+                    status_code=status.HTTP_400_BAD_REQUEST,
+                    detail=f"La categoría con ID {ticket.category_id} no existe."
+                )

-            # Validar sistema
-            if system_uuid:
-                system = await db.get(System, system_uuid)
-                if not system:
-                    raise HTTPException(
-                        status_code=status.HTTP_400_BAD_REQUEST,
-                        detail=f"El sistema con ID {ticket.affected_system_id} no existe."
-                    )
-            
-            db_ticket = Ticket(
-                id=uuid.uuid4(),
-                tenant_id=current_user.tenant_id,
-                ticket_number=ticket_number,
-                subject=ticket.subject,
-                description=ticket.description,
-                category_id=category_uuid,
-                affected_system_id=system_uuid,
-                priority=TicketPriority[ticket.priority.upper()],
-                created_by=current_user.id,
-                status=TicketStatus.NEW,
-                created_at=datetime.utcnow(),
-                updated_at=datetime.utcnow()
-            )
-            
-            db.add(db_ticket)
-            await db.commit()
-            await db.refresh(db_ticket)
-            
-            # ✅ Éxito - retornar ticket creado
-            return {
-                "id": str(db_ticket.id),
-                "ticket_number": db_ticket.ticket_number,
-                "subject": db_ticket.subject,
-                "title": db_ticket.subject,
-                "description": db_ticket.description,
-                "status": db_ticket.status.value,
-                "priority": db_ticket.priority.value,
-                "category_id": str(db_ticket.category_id) if db_ticket.category_id else None,
-                "affected_system_id": str(db_ticket.affected_system_id) if db_ticket.affected_system_id else None,
-                "created_by": str(db_ticket.created_by),
-                "assigned_to": str(db_ticket.assigned_to) if db_ticket.assigned_to else None,
-                "created_at": db_ticket.created_at,
-                "updated_at": db_ticket.updated_at
-            }
-            
-        except ValueError as e:
-            await db.rollback()
-            raise HTTPException(
-                status_code=status.HTTP_400_BAD_REQUEST,
-                detail=f"Invalid UUID format: {str(e)}"
-            )
-        except HTTPException:
-            # Re-lanzar HTTPExceptions directamente
-            await db.rollback()
-            raise
-        except Exception as e:
-            await db.rollback()
-            last_error = e
-            
-            # Si es un error de llave duplicada, reintentar
-            if "duplicate key" in str(e).lower() and "ticket_number" in str(e).lower():
-                if attempt < max_retries - 1:
-                    continue  # Reintentar
-            
-            # Para cualquier otro error, fallar inmediatamente
-            raise HTTPException(
-                status_code=status.HTTP_400_BAD_REQUEST,
-                detail=f"Error creating ticket: {str(e)}"
-            )
-    
-    # Si llegamos aquí después de todos los reintentos
-    raise HTTPException(
-        status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-        detail=f"No se pudo crear el ticket después de {max_retries} intentos: {str(last_error)}"
-    )
-
-
-@router.get("/", response_model=List[TicketResponse])
-async def get_tickets(
-    skip: int = 0,
-    limit: int = 100,
-    status_filter: Optional[str] = None,
-    db: AsyncSession = Depends(get_db),
-    current_user: User = Depends(get_current_user)
-):
-    """
-    Obtener tickets
-    Roles ADMIN/SUPPORT_MANAGER/AGENT: Ven todos los tickets del tenant
-    Roles CLIENT_USER/CLIENT_ADMIN: Solo ven sus propios tickets
-    """
-    # Construir query base filtrado por tenant
-    query = select(Ticket).where(
-        Ticket.tenant_id == current_user.tenant_id
-    )
-    
-    # Si es cliente, solo puede ver sus propios tickets
-    if current_user.role in ["CLIENT_USER", "CLIENT_ADMIN"]:
-        query = query.where(Ticket.created_by == current_user.id)
-    
-    if status_filter:
-        try:
-            status_enum = TicketStatus[status_filter.upper()]
-            query = query.where(Ticket.status == status_enum)
-        except KeyError:
-            raise HTTPException(
-                status_code=status.HTTP_400_BAD_REQUEST,
-                detail=f"Invalid status: {status_filter}"
-            )
-    
-    query = query.order_by(Ticket.created_at.desc()).offset(skip).limit(limit)
-    
-    result = await db.execute(query)
-    tickets = result.scalars().all()
-    
-    # ✅ CORREGIDO: Usar affected_system_id
-    return [
-        {
-            "id": str(t.id),
-            "ticket_number": t.ticket_number,
-            "subject": t.subject,
-            "title": t.subject,
-            "description": t.description,
-            "status": t.status.value,
-            "priority": t.priority.value,
-            "category_id": str(t.category_id) if t.category_id else None,
-            "affected_system_id": str(t.affected_system_id) if t.affected_system_id else None,  # ✅ CORREGIDO
-            "created_by": str(t.created_by),
-            "assigned_to": str(t.assigned_to) if t.assigned_to else None,
-            "created_at": t.created_at,
-            "updated_at": t.updated_at
+        # Validar si el system_id existe en la tabla affected_systems
+        if system_uuid:
+            system = await db.get(System, system_uuid)
+            if not system:
+                raise HTTPException(
+                    status_code=status.HTTP_400_BAD_REQUEST,
+                    detail=f"El sistema con ID {ticket.affected_system_id} no existe."
+                )
+        
+        db_ticket = Ticket(
+            id=uuid.uuid4(),
+            tenant_id=current_user.tenant_id,
+            ticket_number=ticket_number,
+            subject=ticket.subject,
+            description=ticket.description,
+            category_id=category_uuid,
+            affected_system_id=system_uuid,  # ✅ CORREGIDO: Nombre correcto del campo
+            priority=TicketPriority[ticket.priority.upper()],
+            created_by=current_user.id,
+            status=TicketStatus.NEW,
+            created_at=datetime.utcnow(),
+            updated_at=datetime.utcnow()
+        )
+        
+        db.add(db_ticket)
+        await db.commit()
+        await db.refresh(db_ticket)
+        
+        # ✅ CORREGIDO: Usar affected_system_id en respuesta
+        return {
+            "id": str(db_ticket.id),
+            "ticket_number": db_ticket.ticket_number,
+            "subject": db_ticket.subject,
+            "title": db_ticket.subject,
+            "description": db_ticket.description,
+            "status": db_ticket.status.value,
+            "priority": db_ticket.priority.value,
+            "category_id": str(db_ticket.category_id) if db_ticket.category_id else None,
+            "affected_system_id": str(db_ticket.affected_system_id) if db_ticket.affected_system_id else None,  # ✅ CORREGIDO
+            "created_by": str(db_ticket.created_by),
+            "assigned_to": str(db_ticket.assigned_to) if db_ticket.assigned_to else None,
+            "created_at": db_ticket.created_at,
+            "updated_at": db_ticket.updated_at
        }
-        for t in tickets
-    ]
-
-
-@router.get("/admin/all", response_model=List[dict])
-async def get_all_tickets_admin(
-    skip: int = 0,
-    limit: int = 100,
-    status_filter: Optional[str] = None,
-    priority_filter: Optional[str] = None,
-    tenant_id_filter: Optional[str] = None,
-    category_filter: Optional[str] = None,
-    assigned_to_filter: Optional[str] = None,
-    search: Optional[str] = None,
+        
+    except ValueError as e:
+        await db.rollback()
+        raise HTTPException(
+            status_code=status.HTTP_400_BAD_REQUEST,
+            detail=f"Invalid UUID format: {str(e)}"
+        )
    date_from: Optional[str] = None,
    date_to: Optional[str] = None,
    db: AsyncSession = Depends(get_db),
@@ -414,8 +311,6 @@ async def get_ticket(
 ):
    """
    Obtener un ticket específico
-    Roles ADMIN/SUPPORT_MANAGER/AGENT: Pueden ver todos los tickets del tenant
-    Roles CLIENT_USER/CLIENT_ADMIN: Solo pueden ver sus propios tickets
    """
    try:
        ticket_uuid = uuid.UUID(ticket_id)
@@ -425,16 +320,12 @@ async def get_ticket(
            detail="Invalid ticket ID format"
        )
    
-    # Construir query basado en el rol del usuario
    query = select(Ticket).where(
        Ticket.id == ticket_uuid,
-        Ticket.tenant_id == current_user.tenant_id
+        Ticket.tenant_id == current_user.tenant_id,
+        Ticket.created_by == current_user.id
    )
    
-    # Si es cliente, solo puede ver sus propios tickets
-    if current_user.role in ["CLIENT_USER", "CLIENT_ADMIN"]:
-        query = query.where(Ticket.created_by == current_user.id)
-    
    result = await db.execute(query)
    ticket = result.scalars().first()
    
@@ -471,8 +362,6 @@ async def update_ticket(
 ):
    """
    Actualizar un ticket
-    Roles ADMIN/SUPPORT_MANAGER/AGENT: Pueden actualizar cualquier ticket del tenant
-    Roles CLIENT_USER/CLIENT_ADMIN: Solo pueden actualizar sus propios tickets
    """
    try:
        ticket_uuid = uuid.UUID(ticket_id)
@@ -482,16 +371,12 @@ async def update_ticket(
            detail="Invalid ticket ID format"
        )
    
-    # Construir query basado en el rol del usuario
    query = select(Ticket).where(
        Ticket.id == ticket_uuid,
-        Ticket.tenant_id == current_user.tenant_id
+        Ticket.tenant_id == current_user.tenant_id,
+        Ticket.created_by == current_user.id
    )
    
-    # Si es cliente, solo puede actualizar sus propios tickets
-    if current_user.role in ["CLIENT_USER", "CLIENT_ADMIN"]:
-        query = query.where(Ticket.created_by == current_user.id)
-    
    result = await db.execute(query)
    db_ticket = result.scalars().first()
    
@@ -553,8 +438,6 @@ async def close_ticket(
 ):
    """
    Cerrar un ticket
-    Roles ADMIN/SUPPORT_MANAGER/AGENT: Pueden cerrar cualquier ticket del tenant
-    Roles CLIENT_USER/CLIENT_ADMIN: Solo pueden cerrar sus propios tickets
    """
    try:
        ticket_uuid = uuid.UUID(ticket_id)
@@ -564,16 +447,12 @@ async def close_ticket(
            detail="Invalid ticket ID format"
        )
    
-    # Construir query basado en el rol del usuario
    query = select(Ticket).where(
        Ticket.id == ticket_uuid,
-        Ticket.tenant_id == current_user.tenant_id
+        Ticket.tenant_id == current_user.tenant_id,
+        Ticket.created_by == current_user.id
    )
    
-    # Si es cliente, solo puede cerrar sus propios tickets
-    if current_user.role in ["CLIENT_USER", "CLIENT_ADMIN"]:
-        query = query.where(Ticket.created_by == current_user.id)
-    
    result = await db.execute(query)
    db_ticket = result.scalars().first()