From e554c4fca3ac120ee21ca3993985992e90841045 Mon Sep 17 00:00:00 2001 From: AlexeerCT Date: Fri, 2 Jan 2026 12:28:44 -0600 Subject: [PATCH] feat: Refactor logging in exchange rate API and remove unnecessary console statements in various components --- docker-compose.prod.yml | 1 + .../lib/api/dashboard/a76/exchange-rate.ts | 19 ++++++------------- .../pedimentos/edit/dates-tab-form.svelte | 6 ++---- .../edit/other-data-tab-form.svelte | 7 ++----- .../package-transportation-tab-form.svelte | 17 +---------------- 5 files changed, 12 insertions(+), 38 deletions(-) diff --git a/docker-compose.prod.yml b/docker-compose.prod.yml index 7a676940..eb05fe4c 100644 --- a/docker-compose.prod.yml +++ b/docker-compose.prod.yml @@ -229,6 +229,7 @@ services: - ./scripts/frontend-entrypoint.sh:/frontend-entrypoint.sh:ro networks: - frontend-net + - backend-net - auth-net restart: unless-stopped command: ["pnpm", "start"] diff --git a/frontend/src/lib/api/dashboard/a76/exchange-rate.ts b/frontend/src/lib/api/dashboard/a76/exchange-rate.ts index 690d3e9c..89dae9dc 100644 --- a/frontend/src/lib/api/dashboard/a76/exchange-rate.ts +++ b/frontend/src/lib/api/dashboard/a76/exchange-rate.ts @@ -25,30 +25,23 @@ export interface ExchangeRateListResponse { * Get exchange rate by date */ export async function getExchangeRateByDate(date: string, companyId: number): Promise { - try { - console.log('📡 [API] Solicitando tipos de cambio para company_id:', companyId); + try { // Get all exchange rates and filter by date on client side - const response = await api.get(`/v1/a76/exchange-rate/?company_id=${companyId}`); - - console.log('📡 [API] Respuesta recibida:', response.data?.total, 'tipos de cambio'); + const response = await api.get(`/v1/a76/exchange-rate/?company_id=${companyId}`); if (response.data && response.data.items && response.data.items.length > 0) { // Filter by date and find USD exchange rate - const dateOnly = date.split('T')[0]; // Get YYYY-MM-DD part - console.log('🔍 [API] Buscando fecha:', dateOnly, 'en', response.data.items.length, 'registros'); + const dateOnly = date.split('T')[0]; // Get YYYY-MM-DD part const matchingRates = response.data.items.filter(rate => { const rateDate = rate.date.split('T')[0]; - const matches = rateDate === dateOnly && rate.foreign_currency === 'USD'; - console.log(' - Comparando:', rateDate, '===', dateOnly, '&& USD ===', rate.foreign_currency, '→', matches); + const matches = rateDate === dateOnly && rate.foreign_currency === 'USD'; return matches; }); - - console.log('✅ [API] Encontrados', matchingRates.length, 'tipos de cambio que coinciden'); + return matchingRates.length > 0 ? matchingRates[0] : null; } - - console.log('⚠️ [API] No hay datos en la respuesta'); + return null; } catch (error) { console.error('❌ [API] Error fetching exchange rate:', error); diff --git a/frontend/src/lib/components/dashboard/pedimentos/edit/dates-tab-form.svelte b/frontend/src/lib/components/dashboard/pedimentos/edit/dates-tab-form.svelte index 2e52e1ce..2b45810e 100644 --- a/frontend/src/lib/components/dashboard/pedimentos/edit/dates-tab-form.svelte +++ b/frontend/src/lib/components/dashboard/pedimentos/edit/dates-tab-form.svelte @@ -25,8 +25,7 @@ // Actualizar formData solo cuando el pedimento cambie desde el servidor $effect(() => { - const currentObservations = pedimento?.observations ?? null; - console.log('🔄 Pedimento changed in dates-tab-form:', currentObservations); + const currentObservations = pedimento?.observations ?? null; // Solo actualizar si el valor del servidor cambió realmente if (currentObservations !== lastServerObservations) { @@ -34,8 +33,7 @@ formData = { observaciones: currentObservations || '' }; - exists = !!currentObservations; - console.log('✅ Updated formData.observaciones:', formData.observaciones); + exists = !!currentObservations; } }); diff --git a/frontend/src/lib/components/dashboard/pedimentos/edit/other-data-tab-form.svelte b/frontend/src/lib/components/dashboard/pedimentos/edit/other-data-tab-form.svelte index 9e8dd0dc..b85cfa5a 100644 --- a/frontend/src/lib/components/dashboard/pedimentos/edit/other-data-tab-form.svelte +++ b/frontend/src/lib/components/dashboard/pedimentos/edit/other-data-tab-form.svelte @@ -163,9 +163,7 @@ // Solo actualizar si las configuraciones cambiaron if (configHash !== lastServerConfigHash) { - lastServerConfigHash = configHash; - console.log('🔄 Cargando datos del servidor en other-data-tab-form'); - console.log('📥 pedimento_config_updates del servidor:', pedimento.pedimento_config_updates); + lastServerConfigHash = configHash; // Mapear pedimento_config_calculations if (pedimento.pedimento_config_calculations) { @@ -214,8 +212,7 @@ formData.actualizar_advalorem = updates.update_advalorem ?? false; formData.actualizar_dta = updates.update_dta ?? false; formData.actualizar_cc = updates.update_cc ?? false; - formData.actualizar_ieps = updates.update_ieps ?? false; - console.log('✅ Mapeado update_dta:', updates.update_dta, '→ formData.actualizar_dta:', formData.actualizar_dta); + formData.actualizar_ieps = updates.update_ieps ?? false; } // Mapear pedimento_config_update_rectification diff --git a/frontend/src/lib/components/dashboard/pedimentos/edit/package-transportation-tab-form.svelte b/frontend/src/lib/components/dashboard/pedimentos/edit/package-transportation-tab-form.svelte index 87a72b7c..32d48f55 100644 --- a/frontend/src/lib/components/dashboard/pedimentos/edit/package-transportation-tab-form.svelte +++ b/frontend/src/lib/components/dashboard/pedimentos/edit/package-transportation-tab-form.svelte @@ -95,25 +95,10 @@ // Cargar datos del pedimento cuando está disponible $effect(() => { if (pedimento && pedimento.pedimento_transport_means) { - const transport = pedimento.pedimento_transport_means; - // Por ahora solo log para ver qué datos vienen - console.log('📦 pedimento_transport_means del servidor:', transport); + const transport = pedimento.pedimento_transport_means; } }); - // Log cuando el componente se monta/desmonta - $effect(() => { - console.log('🚀 BultosTransportesTabForm montado - Datos actuales:', { - transportes: formData.transportes.length, - guias: formData.guias.length, - precintos: formData.precintos.length, - contenedores: formData.contenedores.length - }); - - return () => { - console.log('💥 BultosTransportesTabForm desmontado'); - }; - }); // Estados para diálogos let isTransporteDialogOpen = $state(false);