refactor: remove console.log statements and unnecessary logging in various components
This commit is contained in:
@@ -129,10 +129,6 @@ class FAClassService:
|
||||
db.commit()
|
||||
db.refresh(new_fa_class)
|
||||
|
||||
logger.info(
|
||||
f"Created fixed asset class {new_fa_class.id} for class_id {new_fa_class.class_id}"
|
||||
)
|
||||
|
||||
return new_fa_class
|
||||
|
||||
except IntegrityError as e:
|
||||
@@ -175,8 +171,6 @@ class FAClassService:
|
||||
db.commit()
|
||||
db.refresh(fa_class)
|
||||
|
||||
logger.info(f"Updated fixed asset class {fa_class_id}")
|
||||
|
||||
return fa_class
|
||||
|
||||
except IntegrityError as e:
|
||||
@@ -208,8 +202,6 @@ class FAClassService:
|
||||
db.delete(fa_class)
|
||||
db.commit()
|
||||
|
||||
logger.info(f"Deleted fixed asset class {fa_class_id}")
|
||||
|
||||
except IntegrityError as e:
|
||||
db.rollback()
|
||||
logger.error(f"IntegrityError deleting fixed asset class: {str(e)}")
|
||||
|
||||
@@ -45,9 +45,6 @@ async def create_fa_class(
|
||||
current_user: Dict[str, Any] = Depends(get_current_user),
|
||||
):
|
||||
"""Create a fixed asset class (both base class and FA extension)"""
|
||||
import logging
|
||||
logger = logging.getLogger(__name__)
|
||||
logger.info(f"create_fa_class endpoint called with: {class_data.model_dump()}")
|
||||
|
||||
tenant_id = validate_access_to_resource(db, company_id, current_user)
|
||||
|
||||
|
||||
@@ -40,7 +40,6 @@ class ClassService:
|
||||
"""
|
||||
Get all classes for a tenant with pagination and filters
|
||||
"""
|
||||
logger.info(f"get_all called with tenant_id={tenant_id}, company_id={company_id}, skip={skip}, limit={limit}")
|
||||
query = db.query(Class).filter(
|
||||
Class.tenant_id == tenant_id, Class.company_id == company_id
|
||||
)
|
||||
@@ -72,7 +71,6 @@ class ClassService:
|
||||
total = query.count()
|
||||
items = query.offset(skip).limit(limit).all()
|
||||
|
||||
logger.info(f"get_all returning {len(items)} items out of {total} total")
|
||||
return items, total
|
||||
|
||||
@staticmethod
|
||||
@@ -149,8 +147,6 @@ class ClassService:
|
||||
company_id: int,
|
||||
) -> Optional[Class]:
|
||||
"""Update a class"""
|
||||
logger.info(f"Update called for class_id={class_id}, tenant_id={tenant_id}, company_id={company_id}")
|
||||
logger.info(f"Update data received: {class_data.model_dump(exclude_unset=True)}")
|
||||
|
||||
class_obj = ClassService.get_by_id(db, class_id, tenant_id, company_id)
|
||||
if not class_obj:
|
||||
@@ -158,7 +154,6 @@ class ClassService:
|
||||
return None
|
||||
|
||||
update_data = class_data.model_dump(exclude_unset=True)
|
||||
logger.info(f"Update data after model_dump: {update_data}")
|
||||
|
||||
# Validate material_key exists if provided
|
||||
if "material_key" in update_data and update_data["material_key"]:
|
||||
@@ -182,7 +177,6 @@ class ClassService:
|
||||
Class.id != class_id # Exclude current class
|
||||
).first()
|
||||
|
||||
logger.info(f"Checking for duplicate class_code '{new_code}'")
|
||||
if existing_class:
|
||||
logger.warning(f"Duplicate class_code found: {existing_class.id}")
|
||||
raise HTTPException(
|
||||
@@ -194,10 +188,8 @@ class ClassService:
|
||||
setattr(class_obj, field, value)
|
||||
|
||||
try:
|
||||
logger.info(f"Attempting to commit changes for class {class_id}")
|
||||
db.commit()
|
||||
db.refresh(class_obj)
|
||||
logger.info(f"Successfully updated class {class_id}")
|
||||
return class_obj
|
||||
except IntegrityError as e:
|
||||
db.rollback()
|
||||
@@ -253,9 +245,6 @@ class ClassService:
|
||||
Create a fixed asset class (both a76.classes and a24.fa_classes)
|
||||
Returns a dict with both records combined
|
||||
"""
|
||||
import logging
|
||||
logger = logging.getLogger(__name__)
|
||||
logger.info(f"create_fa_class called with data: {class_data.model_dump()}")
|
||||
|
||||
from api.v1.modules.a24.fa.fa_classes.models import QClasses
|
||||
|
||||
|
||||
@@ -147,12 +147,6 @@ class ItemService:
|
||||
lines_data = item_data.lines or []
|
||||
item_dict = item_data.model_dump(exclude={"lines"})
|
||||
|
||||
# DEBUG: Log incoming data
|
||||
print(f"\n🔍 DEBUG CREATE ITEM:")
|
||||
print(f" Item data: {item_dict}")
|
||||
print(f" Lines count: {len(lines_data)}")
|
||||
print(f" Tenant ID: {tenant_id}, Company ID: {company_id}")
|
||||
|
||||
# Add tenant and company
|
||||
item_dict["tenant_id"] = tenant_id
|
||||
item_dict["company_id"] = company_id
|
||||
@@ -162,11 +156,8 @@ class ItemService:
|
||||
db.add(db_item)
|
||||
db.flush() # Get the item ID
|
||||
|
||||
print(f" ✅ Item created with ID: {db_item.id}")
|
||||
|
||||
# Create line items if provided
|
||||
for idx, line_data in enumerate(lines_data):
|
||||
print(f"\n 📝 Processing line {idx + 1}/{len(lines_data)}")
|
||||
# Extract nested data from line
|
||||
financial_data = line_data.financial
|
||||
quantity_data = line_data.quantity
|
||||
@@ -174,13 +165,6 @@ class ItemService:
|
||||
description_data = line_data.description
|
||||
reference_data = line_data.reference
|
||||
|
||||
print(f" Line data: {line_data.model_dump()}")
|
||||
print(f" Has financial: {financial_data is not None}")
|
||||
print(f" Has quantity: {quantity_data is not None}")
|
||||
print(f" Has customs: {customs_data is not None}")
|
||||
print(f" Has description: {description_data is not None}")
|
||||
print(f" Has reference: {reference_data is not None}")
|
||||
|
||||
line_dict = line_data.model_dump(
|
||||
exclude={
|
||||
"financial",
|
||||
@@ -198,7 +182,6 @@ class ItemService:
|
||||
db_line = LineItem(**line_dict)
|
||||
db.add(db_line)
|
||||
db.flush() # Get the line ID
|
||||
print(f" ✅ Line created with ID: {db_line.id}")
|
||||
|
||||
# Create financial data if provided
|
||||
if financial_data:
|
||||
@@ -206,7 +189,6 @@ class ItemService:
|
||||
financial_dict["item_line_id"] = db_line.id
|
||||
db_financial = LineFinancial(**financial_dict)
|
||||
db.add(db_financial)
|
||||
print(f" ✅ Financial data added")
|
||||
|
||||
# Create quantity data if provided
|
||||
if quantity_data:
|
||||
@@ -214,7 +196,6 @@ class ItemService:
|
||||
quantity_dict["item_line_id"] = db_line.id
|
||||
db_quantity = LineQuantity(**quantity_dict)
|
||||
db.add(db_quantity)
|
||||
print(f" ✅ Quantity data added")
|
||||
|
||||
# Create customs data if provided
|
||||
if customs_data:
|
||||
@@ -222,7 +203,6 @@ class ItemService:
|
||||
customs_dict["item_line_id"] = db_line.id
|
||||
db_customs = LineCustom(**customs_dict)
|
||||
db.add(db_customs)
|
||||
print(f" ✅ Customs data added")
|
||||
|
||||
# Create description data if provided
|
||||
if description_data:
|
||||
@@ -230,20 +210,17 @@ class ItemService:
|
||||
description_dict["item_line_id"] = db_line.id
|
||||
db_description = LineDescription(**description_dict)
|
||||
db.add(db_description)
|
||||
print(f" ✅ Description data added")
|
||||
|
||||
|
||||
# Create reference data if provided
|
||||
if reference_data:
|
||||
reference_dict = reference_data.model_dump()
|
||||
reference_dict["item_line_id"] = db_line.id
|
||||
db_reference = LineReference(**reference_dict)
|
||||
db.add(db_reference)
|
||||
print(f" ✅ Reference data added")
|
||||
|
||||
print(f"\n 💾 Committing transaction...")
|
||||
db.commit()
|
||||
db.refresh(db_item)
|
||||
print(f" ✅ Transaction committed successfully!")
|
||||
|
||||
return db_item
|
||||
|
||||
except IntegrityError as e:
|
||||
|
||||
@@ -130,7 +130,6 @@ class LicenseService:
|
||||
try:
|
||||
self.db.commit()
|
||||
self.db.refresh(license)
|
||||
logger.info(f"License updated for tenant {tenant_id}")
|
||||
return LicenseResponseDTO.model_validate(license)
|
||||
except Exception as e:
|
||||
self.db.rollback()
|
||||
|
||||
@@ -62,8 +62,6 @@ class TenantService:
|
||||
self.db.commit()
|
||||
self.db.refresh(db_tenant)
|
||||
|
||||
logger.info(f"Tenant created: {db_tenant.id} - {db_tenant.name}")
|
||||
|
||||
return TenantResponseDTO.model_validate(db_tenant)
|
||||
|
||||
except IntegrityError as e:
|
||||
@@ -148,7 +146,6 @@ class TenantService:
|
||||
try:
|
||||
self.db.commit()
|
||||
self.db.refresh(tenant)
|
||||
logger.info(f"Tenant updated: {tenant_id}")
|
||||
return TenantResponseDTO.model_validate(tenant)
|
||||
except Exception as e:
|
||||
self.db.rollback()
|
||||
@@ -174,7 +171,6 @@ class TenantService:
|
||||
|
||||
try:
|
||||
self.db.commit()
|
||||
logger.info(f"Tenant deleted (soft): {tenant_id}")
|
||||
return True
|
||||
except Exception as e:
|
||||
self.db.rollback()
|
||||
@@ -204,7 +200,6 @@ class TenantService:
|
||||
try:
|
||||
self.db.commit()
|
||||
self.db.refresh(tenant)
|
||||
logger.info(f"Tenant upgraded to dedicated DB: {tenant_id}")
|
||||
return TenantResponseDTO.model_validate(tenant)
|
||||
except Exception as e:
|
||||
self.db.rollback()
|
||||
|
||||
Reference in New Issue
Block a user