From 4b2a3da6113f27f61aa687e4d73bebf6e495fe03 Mon Sep 17 00:00:00 2001
From: AlexeerCT <acazares@aduanasoft.com.mx>
Date: Tue, 24 Mar 2026 15:28:41 -0500
Subject: [PATCH] Refactor database URL handling in Alembic environment

- Introduced a new function to normalize database URLs for Alembic, ensuring compatibility with different PostgreSQL drivers.
- Updated the `get_database_url` function to prioritize the use of the `TEST_DATABASE_URL` environment variable for CI and testing scenarios.
- Enhanced error messaging to clarify configuration requirements for database connections.

This change aims to improve the flexibility and reliability of database connections in the testing environment.
---
 .gitea/workflows/build.yml |  2 +-
 backend/alembic/env.py     | 25 +++++++++++++++++++++++--
 2 files changed, 24 insertions(+), 3 deletions(-)

diff --git a/.gitea/workflows/build.yml b/.gitea/workflows/build.yml
index 34b00be4..23a2f909 100644
--- a/.gitea/workflows/build.yml
+++ b/.gitea/workflows/build.yml
@@ -64,7 +64,7 @@ jobs:
           python -m pip install --upgrade pip
           pip install -r "$GITHUB_WORKSPACE/backend/requirements.txt"
           cd "$GITHUB_WORKSPACE/backend"
-          export DATABASE_URL="$TEST_DATABASE_URL"
+          export TEST_DATABASE_URL="$TEST_DATABASE_URL"
           alembic upgrade head
           pytest -q tests -v -ra -s
 
diff --git a/backend/alembic/env.py b/backend/alembic/env.py
index fbe67248..bfbd92f1 100644
--- a/backend/alembic/env.py
+++ b/backend/alembic/env.py
@@ -18,9 +18,29 @@ logger = logging.getLogger(__name__)
 config = context.config
 
 
+def _normalize_alembic_sqlalchemy_url(url: str) -> str:
+    """Alembic usa el driver síncrono psycopg2; normaliza DSN típicos de app/tests."""
+    url = url.strip()
+    if url.startswith("postgresql+asyncpg://"):
+        return url.replace("postgresql+asyncpg://", "postgresql+psycopg2://", 1)
+    if url.startswith("postgresql+psycopg2://"):
+        return url
+    if url.startswith("postgresql://"):
+        return url.replace("postgresql://", "postgresql+psycopg2://", 1)
+    if url.startswith("postgres://"):
+        return url.replace("postgres://", "postgresql+psycopg2://", 1)
+    return url
+
+
 def get_database_url():
     """Obtiene la URL de la base de datos (PostgreSQL) desde variables de entorno o alembic.ini."""
-    # Intentar construir desde variables de entorno primero
+    # CI / pytest: misma URL que los tests (secret TEST_DATABASE_URL) o DATABASE_URL explícita
+    for env_key in ("TEST_DATABASE_URL"):
+        raw = os.environ.get(env_key)
+        if raw and raw.strip():
+            return _normalize_alembic_sqlalchemy_url(raw)
+
+    # Construcción desde settings (CORE_DB_* en .env / entorno)
     host = settings.CORE_DB_HOST
     db = settings.CORE_DB_NAME
     user = settings.CORE_DB_USER
@@ -41,7 +61,8 @@ def get_database_url():
     if not url:
         raise RuntimeError(
             "No se ha configurado la cadena de conexión a PostgreSQL. "
-            "Proporciona las variables de entorno POSTGRES_* o configura sqlalchemy.url en alembic.ini"
+            "Define TEST_DATABASE_URL o DATABASE_URL, o CORE_DB_HOST/CORE_DB_USER/CORE_DB_PASSWORD/CORE_DB_NAME, "
+            "o sqlalchemy.url en alembic.ini"
         )
 
     return url