From 19472b840c1578fb36f77791773dc243dc33db29 Mon Sep 17 00:00:00 2001 From: acazares Date: Sun, 2 Nov 2025 13:53:29 -0600 Subject: [PATCH] refactor: Remove console logs and warnings from authentication and API handling --- frontend/src/lib/api.ts | 9 --------- frontend/src/lib/auth.ts | 5 +---- frontend/src/lib/components/login-form.svelte | 1 - frontend/src/lib/sso.ts | 6 ------ .../src/routes/auth/callback/+page.server.ts | 13 ------------- frontend/src/routes/auth/callback/+page.svelte | 9 +-------- frontend/src/routes/dashboard/+layout.server.ts | 13 +++---------- .../code_pedimento_regimens/+page.server.ts | 13 +------------ .../code_pedimento_regimens/+page.svelte | 16 ++-------------- 9 files changed, 8 insertions(+), 77 deletions(-) diff --git a/frontend/src/lib/api.ts b/frontend/src/lib/api.ts index d46689f7..8983053b 100644 --- a/frontend/src/lib/api.ts +++ b/frontend/src/lib/api.ts @@ -38,13 +38,10 @@ async function refreshToken(): Promise { const refreshTokenValue = localStorage.getItem('refresh_token'); if (!refreshTokenValue) { - console.warn('🔄 No refresh token available'); return null; } try { - console.log('🔄 [API] Intentando refrescar token...'); - const response = await fetch(`${API_BASE_URL}/v1/auth/refresh`, { method: 'POST', headers: { @@ -75,7 +72,6 @@ async function refreshToken(): Promise { // Guardar los nuevos tokens if (data.access_token) { - console.log('✅ [API] Token refrescado exitosamente'); localStorage.setItem('access_token', data.access_token); if (data.refresh_token) { @@ -147,8 +143,6 @@ async function fetchApi( // Si recibimos 401 o 403 y no es el endpoint de refresh, intentar refrescar el token if ((response.status === 401 || response.status === 403) && !endpoint.includes('/auth/refresh') && retryCount === 0) { - console.warn(`⚠️ [API] ${response.status} recibido en ${endpoint}, intentando refrescar token...`); - console.log(`⚠️ [API] Token actual disponible:`, token ? 'Sí (parcial: ' + token.substring(0, 20) + '...)' : 'No'); isRefreshing = true; try { @@ -156,13 +150,11 @@ async function fetchApi( if (newToken) { // Token refrescado exitosamente - console.log(`✅ [API] Reintentando petición a ${endpoint} con nuevo token`); onTokenRefreshed(newToken); isRefreshing = false; // Reintentar la petición original con el nuevo token return await fetchApi(endpoint, options, 1); } else { - console.error(`❌ [API] No se pudo refrescar el token para ${endpoint}`); isRefreshing = false; // Retornar error 401 para que la capa superior lo maneje return { @@ -171,7 +163,6 @@ async function fetchApi( }; } } catch (refreshError) { - console.error(`❌ [API] Error al refrescar token:`, refreshError); isRefreshing = false; return { error: 'Error al refrescar la sesión', diff --git a/frontend/src/lib/auth.ts b/frontend/src/lib/auth.ts index 6c1c1da6..76eca37b 100644 --- a/frontend/src/lib/auth.ts +++ b/frontend/src/lib/auth.ts @@ -424,7 +424,6 @@ export const refreshAccessToken = async (): Promise => { const refreshToken = localStorage.getItem('refresh_token'); if (!refreshToken) { - console.warn('No refresh token available'); return false; } @@ -452,11 +451,9 @@ export const refreshAccessToken = async (): Promise => { // Actualizar también la cookie setCookie('access_token', newAccessToken); - - console.log('✅ Token refreshed successfully'); return true; + } catch (error) { - console.error('Error refreshing token:', error); await logout(); return false; } diff --git a/frontend/src/lib/components/login-form.svelte b/frontend/src/lib/components/login-form.svelte index afd9ac75..0ac8e091 100644 --- a/frontend/src/lib/components/login-form.svelte +++ b/frontend/src/lib/components/login-form.svelte @@ -38,7 +38,6 @@ const isSecure = window.location.protocol === 'https:'; const secureFlag = isSecure ? '; Secure' : ''; document.cookie = `access_token=; path=/; expires=Thu, 01 Jan 1970 00:00:00 UTC; SameSite=Lax${secureFlag}`; - console.log('🧹 Cookies del cliente limpiadas'); } } diff --git a/frontend/src/lib/sso.ts b/frontend/src/lib/sso.ts index 15b5c132..cb67ee25 100644 --- a/frontend/src/lib/sso.ts +++ b/frontend/src/lib/sso.ts @@ -12,7 +12,6 @@ export type SSOProvider = 'microsoft' | 'google' | 'github'; */ export const loginWithProvider = async (provider: SSOProvider): Promise => { if (!browser) { - console.warn('loginWithProvider solo funciona en el navegador'); return; } @@ -40,11 +39,6 @@ export const loginWithProvider = async (provider: SSOProvider): Promise => // URL de login de Keycloak con el provider específico const loginUrl = `${keycloakUrl}/realms/${realm}/protocol/openid-connect/auth?client_id=${clientId}&redirect_uri=${redirectUri}&response_type=code&scope=openid&kc_idp_hint=${provider}`; - console.log('🔐 Iniciando login con', provider); - console.log('📍 URL de Keycloak:', keycloakUrl); - console.log('🏰 Realm:', realm); - console.log('🔑 Client ID:', clientId); - // Redirigir al usuario al proveedor SSO window.location.href = loginUrl; } catch (error) { diff --git a/frontend/src/routes/auth/callback/+page.server.ts b/frontend/src/routes/auth/callback/+page.server.ts index a0b8b00d..6e0426d5 100644 --- a/frontend/src/routes/auth/callback/+page.server.ts +++ b/frontend/src/routes/auth/callback/+page.server.ts @@ -8,10 +8,6 @@ export const load: PageServerLoad = async ({ url, cookies }) => { const errorParam = url.searchParams.get('error'); const errorDescription = url.searchParams.get('error_description'); - console.log('🔄 [Callback Server] Procesando callback de autenticación'); - console.log('📝 [Callback Server] Código recibido:', code ? 'Sí' : 'No'); - console.log('📝 [Callback Server] State recibido:', state); - if (errorParam) { console.error('❌ [Callback Server] Error en autenticación:', errorParam, errorDescription); throw redirect(303, `/login?error=${encodeURIComponent(errorDescription || errorParam)}`); @@ -34,10 +30,6 @@ export const load: PageServerLoad = async ({ url, cookies }) => { // La redirect_uri debe coincidir exactamente con la registrada en Keycloak const redirectUri = `${url.origin}/auth/callback`; - console.log('🔄 [Callback Server] Intercambiando código por tokens...'); - console.log('📍 [Callback Server] Keycloak URL:', KEYCLOAK_URL); - console.log('📍 [Callback Server] Redirect URI:', redirectUri); - const tokenEndpoint = `${KEYCLOAK_URL}/realms/${KEYCLOAK_REALM}/protocol/openid-connect/token`; const body = new URLSearchParams({ @@ -63,7 +55,6 @@ export const load: PageServerLoad = async ({ url, cookies }) => { } const tokens = await tokenResponse.json(); - console.log('✅ [Callback Server] Tokens recibidos exitosamente'); // Establecer las cookies en el servidor (esto es lo importante) // Las cookies deben ser HttpOnly y Secure en producción @@ -87,8 +78,6 @@ export const load: PageServerLoad = async ({ url, cookies }) => { }); } - console.log('✅ [Callback Server] Cookies establecidas exitosamente'); - // Obtener la URL de redirección del state o ir al dashboard let redirectTo = '/dashboard'; if (state) { @@ -100,8 +89,6 @@ export const load: PageServerLoad = async ({ url, cookies }) => { } } - console.log('🚀 [Callback Server] Redirigiendo a:', redirectTo); - // Redirigir a la página de destino throw redirect(303, redirectTo); diff --git a/frontend/src/routes/auth/callback/+page.svelte b/frontend/src/routes/auth/callback/+page.svelte index 9a6a0d98..27711a62 100644 --- a/frontend/src/routes/auth/callback/+page.svelte +++ b/frontend/src/routes/auth/callback/+page.svelte @@ -1,12 +1,5 @@
diff --git a/frontend/src/routes/dashboard/+layout.server.ts b/frontend/src/routes/dashboard/+layout.server.ts index 94db7853..8c562d3d 100644 --- a/frontend/src/routes/dashboard/+layout.server.ts +++ b/frontend/src/routes/dashboard/+layout.server.ts @@ -24,9 +24,7 @@ export const load: LayoutServerLoad = async ({ cookies, url, fetch }) => { const baseUrl = apiUrl?.endsWith('/') ? apiUrl : `${apiUrl}/`; // Validar el token con el backend para asegurar que sea válido - try { - console.log('🔐 [Dashboard] Validando token con:', `${baseUrl}v1/auth/me`); - + try { const response = await fetch(`${baseUrl}v1/auth/me`, { headers: { 'Authorization': `Bearer ${token}` @@ -34,9 +32,7 @@ export const load: LayoutServerLoad = async ({ cookies, url, fetch }) => { }); // Si el token está expirado (401) y tenemos refresh token, intentar refrescar - if (response.status === 401 && refreshToken) { - console.log('🔄 [Dashboard] Token expirado, intentando refrescar...'); - + if (response.status === 401 && refreshToken) { try { const refreshResponse = await fetch(`${baseUrl}v1/auth/refresh`, { method: 'POST', @@ -70,7 +66,6 @@ export const load: LayoutServerLoad = async ({ cookies, url, fetch }) => { // Usar el nuevo token para obtener la info del usuario token = refreshData.access_token; - console.log('✅ [Dashboard] Token refrescado exitosamente'); // Reintentar la validación con el nuevo token const retryResponse = await fetch(`${baseUrl}v1/auth/me`, { @@ -86,9 +81,7 @@ export const load: LayoutServerLoad = async ({ cookies, url, fetch }) => { user: userData }; } - } else { - console.log('❌ [Dashboard] Refresh token también está expirado'); - } + } } catch (refreshError) { console.error('🔐 [Dashboard] Error al refrescar token:', refreshError); } diff --git a/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.server.ts b/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.server.ts index 603f5785..ff2f87ee 100644 --- a/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.server.ts +++ b/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.server.ts @@ -30,13 +30,7 @@ export const load: PageServerLoad = async ({ cookies, fetch, url, parent }) => { } // Normalizar la URL - const baseUrl = apiUrl?.endsWith('/') ? apiUrl : `${apiUrl}/`; - - console.log('📊 [Code Pedimento Regimens] Fetching data:', { - url: `${baseUrl}v1/code-pedimento-regimens`, - page, - pageSize - }); + const baseUrl = apiUrl?.endsWith('/') ? apiUrl : `${apiUrl}/`; const response = await fetch( `${baseUrl}v1/code-pedimento-regimens?page=${page}&page_size=${pageSize}`, @@ -66,11 +60,6 @@ export const load: PageServerLoad = async ({ cookies, fetch, url, parent }) => { } const data = await response.json(); - - console.log('📊 [Code Pedimento Regimens] Data loaded:', { - total: data.total, - itemsCount: data.items?.length - }); return { items: data.items || [], diff --git a/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.svelte b/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.svelte index 4dda50d2..cd344faf 100644 --- a/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.svelte +++ b/frontend/src/routes/dashboard/reference_data/code_pedimento_regimens/+page.svelte @@ -27,7 +27,6 @@ const localToken = localStorage.getItem('access_token'); if (cookieToken && cookieToken !== localToken) { - console.log('🔄 [Page] Sincronizando token de cookies a localStorage'); localStorage.setItem('access_token', cookieToken); } @@ -36,7 +35,6 @@ const localRefreshToken = localStorage.getItem('refresh_token'); if (cookieRefreshToken && cookieRefreshToken !== localRefreshToken) { - console.log('🔄 [Page] Sincronizando refresh_token de cookies a localStorage'); localStorage.setItem('refresh_token', cookieRefreshToken); } } @@ -57,18 +55,9 @@ loading = true; error = null; - try { - console.log(`📊 [Page] Cargando página ${currentPage + 1}...`); - console.log(`📊 [Page] Token disponible:`, localStorage.getItem('access_token') ? 'Sí' : 'No'); - + try { const response = await codePedimentoRegimensApi.list(currentPage + 1, pageSize); - console.log(`📊 [Page] Respuesta recibida:`, { - error: response.error, - status: response.status, - hasData: !!response.data - }); - if (response.error) { console.error('📊 [Page] Error en loadMore:', response.error, 'Status:', response.status); @@ -85,8 +74,7 @@ return; } - if (response.data?.items) { - console.log(`📊 [Page] Cargados ${response.data.items.length} items adicionales`); + if (response.data?.items) { // Agregar los nuevos items al array existente allItems = [...allItems, ...response.data.items]; currentPage++;